I just change the css file to make the page looks better.#12
Open
boyongjiong wants to merge 1 commit into
Open
I just change the css file to make the page looks better.#12boyongjiong wants to merge 1 commit into
boyongjiong wants to merge 1 commit into
Conversation
添加.gitignore 忽略某些文件
|
Great @boyongjiong. |
|
Could anyone update it to the server please:~) |
grubnubble
reviewed
Jul 12, 2018
grubnubble
left a comment
grubnubble
left a comment
There was a problem hiding this comment.
You don't need to include npm-debug.log or loupe.bundle.css. Shouldn't we add the bundle files to the .gitignore?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm confused that when I use make to build loupe.bundle.css, some css just lost. Just as this picture shows:
I wonder wether there are any other settings to be done?
As below shows the website after my work:
