chore: Pin github actions.#500
Merged
Merged
Conversation
kinyoklion
force-pushed
the
rlamb/pin-actions-2
branch
from
99804e3 to
02b6774
Compare
keelerm84
reviewed
Nov 4, 2025
keelerm84
approved these changes
Nov 4, 2025
devin-ai-integration Bot
added a commit
that referenced
this pull request
Mar 10, 2026
The test-ubuntu-curl job had both 'uses' and 'run' on the same step, which is invalid in GitHub Actions. This was introduced in commit 5b8bbee (PR #500). The install-curl composite action already handles apt-get installation internally, so the 'run' key was redundant and caused the entire workflow to fail with 0 jobs. Co-Authored-By: rlamb@launchdarkly.com <kingdewman@gmail.com>
2 tasks
kinyoklion
added a commit
that referenced
this pull request
Mar 10, 2026
#507) # fix: remove invalid 'run' key from cmake workflow step ## Summary The `test-ubuntu-curl` job in `.github/workflows/cmake.yml` has a step with both `uses:` and `run:` keys, which is invalid in GitHub Actions (a step must be one or the other). This causes the entire workflow to fail immediately with 0 jobs — the root cause of the failure in [run 22914048955](https://github.com/launchdarkly/cpp-sdks/actions/runs/22914048955). The invalid `run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev` was added in PR #500 (commit 5b8bbee). It is also redundant — the `.github/actions/install-curl` composite action already runs `apt-get install libcurl4-openssl-dev` on Linux internally. The fix simply removes the erroneous `run:` line. ## Review & Testing Checklist for Human - [ ] Verify the [install-curl composite action](https://github.com/launchdarkly/cpp-sdks/blob/main/.github/actions/install-curl/action.yml) still handles Linux curl installation via `apt-get` (it does as of this writing) - [ ] After merging, confirm the `cmake-integration` workflow runs successfully on `main` with all 6 jobs created ### Notes - Requested by: @kinyoklion - [Link to Devin Session](https://app.devin.ai/sessions/8a014c6f323f4134a116aef51d57d9d3) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Fixes a GitHub Actions YAML syntax issue in CI; no production code changes and behavior remains handled by the existing `install-curl` composite action. > > **Overview** > Fixes the `cmake-integration` GitHub Actions workflow by removing an invalid `run` command from the `test-ubuntu-curl` step that already `uses` the `install-curl` composite action. > > This prevents the workflow from failing to start due to an invalid step definition, while keeping curl installation delegated to `./.github/actions/install-curl`. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 6d88ed6. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY --> Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Pins CI actions to specific SHAs across all workflows and adds
apt-get install libcurl4-openssl-devto the Ubuntu curl job..github/workflows/*:actions/checkout,launchdarkly/gh-actions/actions/contract-tests,ilammy/msvc-dev-cmd,MarkusJx/install-boost,cpp-linter/cpp-linter-action,googleapis/release-please-action, and reusablelaunchdarkly/gh-actions/.github/workflows/lint-pr-title.yml.cmake.yml(Ubuntu curl job): add explicit installation oflibcurl4-openssl-devviaapt-get.Written by Cursor Bugbot for commit 7aab6d9. This will update automatically on new commits. Configure here.