feat: add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer#540
Draft
beekld wants to merge 1 commit into
Draft
feat: add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer#540beekld wants to merge 1 commit into
beekld wants to merge 1 commit into
Conversation
9f04fa3 to
ea3b92b
Compare
1780156 to
479e599
Compare
ea3b92b to
142b2ff
Compare
479e599 to
403bdff
Compare
142b2ff to
7ea2f7c
Compare
403bdff to
20da492
Compare
7ea2f7c to
e2824ec
Compare
20da492 to
95351be
Compare
e2824ec to
f0b2aab
Compare
95351be to
7202ca6
Compare
f0b2aab to
f94ce01
Compare
7202ca6 to
1bcd458
Compare
f94ce01 to
eb28df0
Compare
1bcd458 to
a183532
Compare
eb28df0 to
3e76ae5
Compare
a183532 to
e0396ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on #539. Adds an adapter that wraps any FDv1
IDataSynchronizer(e.g. the existingStreamingDataSource) and presents it as anIFDv2Synchronizer. FDv1Init/Upsertcallbacks delivered through an internalIDestinationare translated intoFDv2SourceResult::ChangeSetresults (kFullforInit,kPartialforUpsert), with empty selectors andfdv1_fallback=false.The orchestrator picks this up after
SwitchToFDv1Fallback()once a factory whoseIsFDv1Fallback()returns true is configured. Wiring the adapter into the public config builders is a separate concern, deferred until the Configuration API work.Test plan