Skip to content

feat: add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer#540

Draft
beekld wants to merge 1 commit into
beeklimt/SDK-2379-3from
beeklimt/SDK-2379-4
Draft

feat: add FDv1AdapterSynchronizer wrapping IDataSynchronizer as IFDv2Synchronizer#540
beekld wants to merge 1 commit into
beeklimt/SDK-2379-3from
beeklimt/SDK-2379-4

Conversation

@beekld
Copy link
Copy Markdown
Contributor

@beekld beekld commented May 28, 2026

Summary

Stacked on #539. Adds an adapter that wraps any FDv1 IDataSynchronizer (e.g. the existing StreamingDataSource) and presents it as an IFDv2Synchronizer. FDv1 Init/Upsert callbacks delivered through an internal IDestination are translated into FDv2SourceResult::ChangeSet results (kFull for Init, kPartial for Upsert), with empty selectors and fdv1_fallback=false.

The orchestrator picks this up after SwitchToFDv1Fallback() once a factory whose IsFDv1Fallback() returns true is configured. Wiring the adapter into the public config builders is a separate concern, deferred until the Configuration API work.

Test plan

  • 8 unit tests cover: lazy start, no-restart on second Next, Init→kFull, Upsert→kPartial (both overloads), pending-Next-resolved-as-Shutdown-on-close, ShutdownAsync called once on close (and not at all if never started), Next-after-Close
  • Full server suite green (486 tests)

@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from 9f04fa3 to ea3b92b Compare May 28, 2026 18:22
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 1780156 to 479e599 Compare May 28, 2026 18:24
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from ea3b92b to 142b2ff Compare May 28, 2026 20:19
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 479e599 to 403bdff Compare May 28, 2026 20:20
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from 142b2ff to 7ea2f7c Compare May 28, 2026 23:22
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 403bdff to 20da492 Compare May 28, 2026 23:22
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from 7ea2f7c to e2824ec Compare May 28, 2026 23:52
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 20da492 to 95351be Compare May 28, 2026 23:53
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from e2824ec to f0b2aab Compare May 29, 2026 00:32
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 95351be to 7202ca6 Compare May 29, 2026 00:32
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from f0b2aab to f94ce01 Compare May 29, 2026 21:17
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 7202ca6 to 1bcd458 Compare May 29, 2026 21:17
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from f94ce01 to eb28df0 Compare May 29, 2026 21:20
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from 1bcd458 to a183532 Compare May 29, 2026 21:20
@beekld beekld force-pushed the beeklimt/SDK-2379-3 branch from eb28df0 to 3e76ae5 Compare May 29, 2026 21:45
@beekld beekld force-pushed the beeklimt/SDK-2379-4 branch from a183532 to e0396ff Compare May 29, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant