Merged
Conversation
kinyoklion
force-pushed
the
rlamb/ping-stream-support
branch
from
1e9486b to
dccfd48
Compare
kinyoklion
commented
Nov 4, 2025
| **/coverage/ | ||
| **/.flutter-plugins-dependencies | ||
| **/.flutter-plugins | ||
| **/devtools_options.yaml |
Member
Author
There was a problem hiding this comment.
Unrelated, but this file was created when using the flutter dev tools.
kinyoklion
force-pushed
the
rlamb/ping-stream-support
branch
2 times, most recently
from
2a28719 to
bbcebc5
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/common_client/lib/src/data_sources/streaming_data_source.dart
Outdated
Show resolved
Hide resolved
kinyoklion
force-pushed
the
rlamb/ping-stream-support
branch
from
bbcebc5 to
8f17351
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
kinyoklion
force-pushed
the
rlamb/ping-stream-support
branch
from
8f17351 to
794c4fe
Compare
kinyoklion
force-pushed
the
rlamb/ping-stream-support
branch
from
794c4fe to
77a7bd0
Compare
Member
Author
|
bugbot review |
kinyoklion
commented
Nov 4, 2025
| // we want to poll after 25 seconds. | ||
| final delay = Duration( | ||
| milliseconds: max( | ||
| milliseconds: min( |
Member
Author
There was a problem hiding this comment.
Unrelated minor bug, this should have been min to match the described logic. max will always just be the polling interval.
tanderson-ld
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat: Add support for ping stream.
fix: Expose polling configuration type.
END_COMMIT_OVERRIDE
The primary purpose of this PR is to add ping stream support to allow the flutter client SDK to work with relay proxy in streaming mode.
In order to add this functionality a bit of re-factoring has occurred. The core logic for doing a poll is now encapsulated into a "requestor". This ensures that the process used for making a poll in request to a "ping" event is using the same logic as a polling request.
Note
Adds SSE ping support that triggers a flags poll, extracting shared polling logic into a new Requestor and updating data sources and tests accordingly.
streaming_data_source.dart): handlepingevents; on ping, useRequestorto fetch all flags and emitDataEvent/StatusEvent; supports GET/REPORT; minor logging; exposeshttpClientFactoryfor ping requests.polling_data_source.dart): refactor to useRequestorfor requests; compute method fromuseReport; fix poll reschedule delay calculation; exposehttpClientFactory.requestor.dartencapsulates polling request logic (URL building, headers/body, ETag handling, environment ID extraction, error mapping) and returnsDataSourceEvent?.ld_common_client.dart: build a singlePollingDataSourceConfigand pass it toStreamingDataSourcefor ping-driven polls..gitignore: ignore**/devtools_options.yaml.Written by Cursor Bugbot for commit d7e211b. This will update automatically on new commits. Configure here.