fix: bump SDK deps for EasyJSON removal (v4 cascade)#34
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c05fd21. Configure here.
| github.com/launchdarkly/go-sdk-common/v3 v3.1.0 | ||
| github.com/launchdarkly/go-server-sdk/v7 v7.0.0 | ||
| github.com/stretchr/testify v1.7.0 | ||
| github.com/launchdarkly/go-server-sdk/v7 v7.14.8-0.20260526234754-18487da78db5 |
There was a problem hiding this comment.
go.mod has v3 direct and v4 indirect, reversed
Medium Severity
go-sdk-common/v3 is listed as a direct dependency in go.mod but no source file imports from it anymore. Conversely, go-sdk-common/v4 is marked // indirect despite being directly imported by consul_builder.go, consul_impl.go, and consul_test.go. This indicates go mod tidy was not run after the import rewrites. The direct/indirect markers are inverted, which misrepresents the module's actual dependency graph and may confuse tooling or downstream consumers.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit c05fd21. Configure here.
Updates go-sdk-common /v3 -> /v4 (dev pseudo) and go-server-sdk to the v4 cascade dev pseudo. Module path itself stays /v3. Part of the SDK-2113 EasyJSON removal project. Co-authored-by: Cursor <cursoragent@cursor.com>
c05fd21 to
1198f1b
Compare
…95b9066 Align with go-server-sdk #381 (8ab3995) and flip transitive LD deps to released v4.0.0 / v3.6.1 tags.
The v4 cascade pins go-server-sdk at a pseudo that requires Go 1.24+. Older CI matrix versions cannot parse go 1.24.0 or load SDK export data.
Re-pin to f45511677931 after feat! → fix rebase on go-server-sdk #381.


Summary
Bumps
go-sdk-commonfrom/v3to/v4(andgo-server-sdk/v7to a v4-cascade dev pseudo) so that consumers ofgo-server-sdk-consul/v3building against the new SDK majors can compile.This module itself stays on
/v3— only its dependencies bump..goimports are rewrittengo-sdk-common/v3→/v4.Why now
The SDK-2113 EasyJSON removal project is shipping
go-jsonstream,go-sdk-common, andgo-server-sdk-evaluationas/v4majors. ld-relay imports bothconsul/v3andgo-sdk-common/v4, which produces a type mismatch unless this module's source is bumped to/v4.Dependency Chain (v4 cascade)
Test plan
go build ./...cleango test -short)/v3imports of bumped libs remainingContext
Part of SDK-2113 (epic). Tracks SDK-2119 (cascade). Surfaced during ld-relay's v4 transition.
Stage 5 cleanup
Once
go-sdk-common@v4.0.0and a realgo-server-sdk@v7.x.ytag exist, this PR's pseudo-versions should be flipped to those real versions before merge — or merge as-is and follow up.via LD Research 🤖
Made with Cursor
Note
Low Risk
Import and dependency-only changes with no Consul persistence logic edits; main follow-up is replacing dev pseudo-versions with released tags before merge.
Overview
Aligns this Consul persistent data store module with the go-sdk-common v4 cascade so apps that already use
go-sdk-common/v4(e.g. ld-relay) do not hit type mismatches when wiring this package. Source imports move fromgo-sdk-common/v3to/v4forldvalue,ldlog, andldlogtestin the builder, implementation, and tests; module identity staysgo-server-sdk-consul/v3.go.mod raises the toolchain to Go 1.24.0, bumps go-server-sdk/v7 to a v4-cascade dev pseudo-version, refreshes testify and transitive LaunchDarkly libs (
go-jsonstream/v4, evaluation v4, events, etc.), and updates go.sum. No Consul store behavior changes—only dependency and import alignment.Reviewed by Cursor Bugbot for commit c05fd21. Bugbot is set up for automated code reviews on this repo. Configure here.