Skip to content

chore: Bump golangci-lint to v2.11.1 #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
keelerm84 merged 5 commits into from
Mar 10, 2026
Merged

chore: Bump golangci-lint to v2.11.1 #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e2b76ce
chore: fix errcheck lint issues in test files
devin-ai-integration[bot] Mar 9, 2026
aae0ba1
chore: bump golangci-lint to v2.11.1
devin-ai-integration[bot] Mar 9, 2026
81c6d10
Merge branch 'v4' into devin/1773088670-bump-golangci-lint
keelerm84 Mar 10, 2026
46cc445
chore: use t.Cleanup instead of defer require.NoError for env var cle…
devin-ai-integration[bot] Mar 10, 2026
df9c9ae
add codeowners
keelerm84 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@

# Repository Maintainers
* @launchdarkly/team-sdk-go
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
GOLANGCI_LINT_VERSION=v1.60.1
GOLANGCI_LINT_VERSION=v2.11.1

LINTER=./bin/golangci-lint
LINTER_VERSION_FILE=./bin/.golangci-lint-version-$(GOLANGCI_LINT_VERSION)
Expand Down
5 changes: 3 additions & 2 deletions dynamodb_builder_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/aws/aws-sdk-go-v2/aws"
"github.com/aws/aws-sdk-go-v2/service/dynamodb"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestDataSourceBuilder(t *testing.T) {
Expand Down Expand Up @@ -74,8 +75,8 @@ func TestDataSourceBuilder(t *testing.T) {
})

t.Run("error for invalid configuration", func(t *testing.T) {
os.Setenv("AWS_CA_BUNDLE", "not a real CA file")
defer os.Setenv("AWS_CA_BUNDLE", "")
require.NoError(t, os.Setenv("AWS_CA_BUNDLE", "not a real CA file"))
t.Cleanup(func() { _ = os.Setenv("AWS_CA_BUNDLE", "") })

ds, err := DataStore("t").Build(subsystems.BasicClientContext{})
assert.Error(t, err)
Expand Down
4 changes: 2 additions & 2 deletions dynamodb_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ func TestDataStoreSkipsAndLogsTooLargeItem(t *testing.T) {
ctx.Logging.Loggers = mockLog.Loggers
store, err := makeTestStore("").Build(ctx)
require.NoError(t, err)
defer store.Close()
defer store.Close() //nolint:errcheck // test cleanup

dataPlusBadItem := makeGoodData()
collection := dataPlusBadItem[params.collIndex]
Expand Down Expand Up @@ -163,7 +163,7 @@ func TestDataStoreSkipsAndLogsTooLargeItem(t *testing.T) {
ctx.Logging.Loggers = mockLog.Loggers
store, err := makeTestStore("").Build(ctx)
require.NoError(t, err)
defer store.Close()
defer store.Close() //nolint:errcheck // test cleanup

goodData := makeGoodData()
require.NoError(t, store.Init(goodData))
Expand Down