fix: bump core deps to v4 and remove EasyJSON support#381
Open
aaron-zeisler wants to merge 4 commits into
Open
fix: bump core deps to v4 and remove EasyJSON support#381aaron-zeisler wants to merge 4 commits into
aaron-zeisler wants to merge 4 commits into
Conversation
This was referenced May 29, 2026
aaron-zeisler
added a commit
that referenced
this pull request
May 29, 2026
Pin integration modules at commits that target go-server-sdk v7.15.1-0.20260529202418-8ab3995b9066 (#381).
- go-jsonstream /v3 → /v4 - go-sdk-common /v3 → /v4 - go-server-sdk-evaluation /v3 → /v4 - go-sdk-events v3.5.0 → v3.6.1 - Remove EasyJSON section from README - Rewrite all /v3 imports to /v4 Part of SDK-2113 (EasyJSON removal epic).
Pin consul, dynamodb, and redis-go-redis to their v4 cascade-branch pseudos and rewrite testservice imports to go-sdk-common/v4. Keeps replace go-server-sdk => ../ so contract tests compile against the local root module without waiting for a tagged SDK release.
Pin integration modules at commits that target go-server-sdk v7.15.1-0.20260529202418-8ab3995b9066 (#381).
8ebf071 to
398e2ea
Compare
aaron-zeisler
added a commit
that referenced
this pull request
May 29, 2026
Import rewrites (go-sdk-common/v3 → /v4) belong in #381. This PR only updates testservice dependency pins in go.mod/go.sum alongside ldai, ldotel, and ldmiddleware sub-modules.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updates the root
go-server-sdk/v7module to use the v4 releases of core dependencies, completing the EasyJSON removal for this library.go-jsonstream/v3→/v4(v4.0.0)go-sdk-common/v3→/v4(v4.0.0)go-server-sdk-evaluation/v3→/v4(v4.0.0)go-sdk-eventsv3.5.0 → v3.6.1/v3imports rewritten to/v4Dependency Chain (v4 cascade)
Sequence of events
This PR is intentionally scoped to unblock the v4 cascade without getting stuck on circular dependencies between the root module and its sub-modules:
Only the root module of go-server-sdk has been updated to v4 dependencies and
/v4imports. Sub-modules are handled separately (see below).ldaiandldotelwill be updated in a separate pull request (#382) due to circular dependencies between those sub-modules and the root module. They should merge after this PR lands.testserviceis temporarily configured with pseudo-versions of the integration modules (consul, dynamodb, redis-go-redis) so contract-test CI can compile against v4-capable deps viareplace go-server-sdk => ../. Those pseudo-versions will be replaced with real tagged releases in a subsequent pull request (Stage 5 cleanup).Scope
testservice(pseudo-version pins only)ldai,ldotel(#382)testservicepseudo-versions to real releases;ldmiddlewareif neededTest plan
go build ./...clean (root module)make build-contract-testsclean (testservicewith integration pseudo-versions)go mod tidyproduces no diff/v3imports of bumped libs remaining in root module ortestserviceContext
Part of SDK-2113 (EasyJSON removal epic). Tracks SDK-2119.
via LD Research 🤖
Note
Medium Risk
Wide import and dependency churn touches evaluation, JSON streaming, and contract-test wiring; behavior should be unchanged but regressions could show up in flag evaluation or integration tests until sibling modules (
ldai,ldotel) and real integration tags land.Overview
This PR moves the root
go-server-sdk/v7module onto the v4 LaunchDarkly core libraries and drops optional EasyJSON integration from the product surface.Dependencies:
go.mod/go.sumnow requirego-sdk-common/v4,go-jsonstream/v4, andgo-server-sdk-evaluation/v4, withgo-sdk-eventsbumped to v3.6.1. Indirectmailru/easyjsonandjosharian/internentries are removed from the root module.Code: Imports across the root package tree are rewritten from
/v3to/v4for those libraries (client, datasources, datastore, hooks, tests, etc.).testserviceis updated the same way and temporarily pins integration modules (Consul, DynamoDB, Redis) at pseudo-versions so contract tests can build against this branch.Docs: The README section describing the
launchdarkly_easyjsonbuild tag is removed;config.go/package_info.gocomments now referencego-sdk-common/v4paths.Reviewed by Cursor Bugbot for commit 329fde7. Bugbot is set up for automated code reviews on this repo. Configure here.