chore: scaffold LaunchDarkly Java AI SDK module foundation (AIC-2661)#170
Open
ctawiah wants to merge 3 commits into
Open
chore: scaffold LaunchDarkly Java AI SDK module foundation (AIC-2661)#170ctawiah wants to merge 3 commits into
ctawiah wants to merge 3 commits into
Conversation
Stand up the new lib/java-server-sdk-ai Gradle module with the same build, quality-gate, and release machinery as sibling modules, so later steps land on a CI-enforced base. No SDK behavior yet. - java-library module, Java 8 source/target, checkstyle + jacoco quality gates - api dependency on launchdarkly-java-server-sdk; jmustache for interpolation - internal package excluded from published Javadoc/sources jars - CI workflow over JDK 8/11/17 matrix via shared composite action - registered in release-please manifest/config at 0.1.0 jmustache audit: com.samskivert:jmustache:1.16, BSD 2-Clause, no transitive runtime deps, actively maintained -> approved. Co-authored-by: Cursor <cursoragent@cursor.com>
Place the module under lib/sdk/ alongside the core SDK (lib/sdk/server), mirroring the JS reference layout (packages/sdk/server-ai), instead of the flat lib/java-server-sdk-* add-on pattern. Maven coordinates are unchanged (com.launchdarkly:launchdarkly-java-server-sdk-ai). Updates CI workspace_path and release-please manifest/config keys to the new path. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove the Mustache templating dependency from the foundation module. It will be added in a later step (AIC-2662) once the license / maintenance / transitive -dependency audit is complete. The module's published POM now declares only the base SDK dependency. Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1800281. Configure here.
| "extra-files": [ | ||
| "gradle.properties" | ||
| ] | ||
| }, |
There was a problem hiding this comment.
Release Please publish job missing
Medium Severity
This change registers lib/sdk/server-ai in release-please, but release-please.yml has no output for lib/sdk/server-ai--release_created and no full-release job targeting lib/sdk/server-ai. When release-please marks a release for this component, nothing will publish the artifact to Sonatype/Maven Central.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 1800281. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Requirements
Related issues
Describe the solution you've provided
Stands up the new
lib/sdk/server-aiGradle module from scratch with the same build, quality-gate, and release machinery as sibling modules (lib/sdk/server,lib/java-server-sdk-otel,lib/java-server-sdk-redis-store), so every later step in the epic lands on a solid, CI-enforced base.build.gradle(java-library, Java 8 source/target),settings.gradle,gradle.properties(release-pleaseversion=0.1.0markers),checkstyle.xml,.gitignore,.gitattributes,CHANGELOG.md,README.md, Gradle wrapper, and a documentedpackage-info.java.api 'com.launchdarkly:launchdarkly-java-server-sdk:7.14.0'(it appears in the public signature viaLDClientInterface). A Mustache templating dependency is not added in this PR — it will be introduced in a later step (AIC-2662) once its audit (license / maintenance / transitive deps) is complete. The published POM therefore declares only the base SDK dependency.LD_SKIP_SIGNING.com.launchdarkly.sdk.server.ai.internal, which is excluded from the published Javadoc and sources jars (configured inbuild.gradle, documented inREADME.md/package-info.java)..github/workflows/java-server-sdk-ai.ymlruns the shared CI composite over a JDK 8 / 11 / 17 matrix..release-please-manifest.json(0.1.0) andrelease-please-config.json(launchdarkly-java-server-sdk-ai,extra-files: [gradle.properties]).Verified locally:
./gradlew clean build→ BUILD SUCCESSFUL;./gradlew publishToMavenLocal→com.launchdarkly:launchdarkly-java-server-sdk-ai:0.1.0(jar/sources/javadoc/pom).Describe alternatives you've considered
lib/sdk/next to the core SDK (lib/sdk/server), mirroring the JS reference layout (packages/sdk/server-ai), rather than the flatlib/java-server-sdk-*add-on pattern used by the otel/redis integrations.Additional context
javadoc { failOnError = false }is a temporary shim because an otherwise-empty module trips javadoc's "no classes to document" error; there is aTODO(AIC-2662)to restorefailOnError = trueonce the first public types land.Note
Low Risk
Infrastructure-only scaffolding with no product logic; only adds a new publishable module and CI/release wiring.
Overview
Adds a new
lib/sdk/server-aiGradle module forlaunchdarkly-java-server-sdk-ai(v0.1.0) as the foundation for the Server-Side AI SDK—no AI Config APIs or runtime behavior yet, onlypackage-info.javaundercom.launchdarkly.sdk.server.ai.The build mirrors sibling libraries: Java 8 target,
apidependency onlaunchdarkly-java-server-sdk:7.14.0, checkstyle/jacoco, Maven publish/signing (withLD_SKIP_SIGNING), and exclusion ofcom.launchdarkly.sdk.server.ai.internalfrom published Javadoc/sources. JavadocfailOnErroris temporarily disabled until public types land.CI is wired via
.github/workflows/java-server-sdk-ai.yml, running the shared composite action againstlib/sdk/server-aion a JDK 8 / 11 / 17 matrix. Release Please entries were added in.release-please-manifest.jsonandrelease-please-config.json.Reviewed by Cursor Bugbot for commit 1800281. Bugbot is set up for automated code reviews on this repo. Configure here.