feat: Assert hook execution order for evaluation and track stages#343
Merged
Conversation
aaron-zeisler
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
feat/fdv2.beforeEvaluation-- registration order.afterEvaluation-- reverse of registration order.afterTrack-- registration order.Hooksgroup now owns a shared*atomic.Int64threaded into everyHookCallbackService; the endpoint handler stamps the counter onto each received payload before pushing it onto the channel, so tests can reconstruct cross-hook execution order from the otherwise-independent callback URLs.Hooks.Configure(the prior implementation iterated a Go map, which is randomized), so the ordering assertions are deterministic.Sequencefield onHookExecutionPayloadis harness-internal (json:"-") and is not part of the SDK contract; no contract-test changes are required in SDK repos.Note
Medium Risk
Moderate risk because it changes test-harness hook configuration ordering (from map iteration to explicit order) and introduces new ordering assertions that may fail SDKs with previously-untested behavior.
Overview
Adds ordering coverage for hooks by tracking cross-hook execution order and asserting it in common tests.
Hooksnow preserves registration order explicitly when configuring hooks (avoiding randomized Go map iteration), andHookCallbackServicecan stamp a shared atomicSequenceonto each receivedHookExecutionPayload(new harness-only field) so tests can sort callbacks across distinct hook endpoints.Introduces new tests asserting that
beforeEvaluationandafterTrackexecute in registration order, whileafterEvaluationexecutes in reverse registration order.Reviewed by Cursor Bugbot for commit e59c949. Bugbot is set up for automated code reviews on this repo. Configure here.