fix: iOS26 SwiftUI masking cases#195
Merged
Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Vadman97
approved these changes
May 6, 2026
abelonogov-ld
force-pushed
the
andrey/labels-fix-ios26
branch
from
b7d7a75 to
a999e55
Compare
abelonogov-ld
changed the title
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default mode and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit a999e55. Configure here.
abelonogov-ld
pushed a commit
that referenced
this pull request
May 23, 2026
🤖 I have created a release *beep* *boop* --- ## [0.35.0](0.34.1...0.35.0) (2026-05-23) ### Features * use only one animation flush and and only in case of existing masks ([#191](#191)) ([2a09883](2a09883)) ### Bug Fixes * iOS26 SwiftUI masking cases ([#195](#195)) ([386d0ad](386d0ad)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Touches the session-replay masking pipeline (per-frame layer walk and privacy decisions), so regressions could expose or over-mask UI content, especially on iOS 26 SwiftUI screens. Changes are well-scoped and backed by new targeted tests but still affect core capture behavior.
Overview
Fixes SwiftUI masking on iOS 26 by changing session-replay masking to propagate
.ldMask()/.ldUnmask()/.ldIgnore()via marker areas (projected overlay marker frames) instead of relying on UIKit ancestor relationships, and by adding support for SwiftUI content rendered as layer-only (no backingUIView).Refactors
MaskCollectorinto smaller collaborators (MarkerScanner,MaskingPolicy,MaskGeometry) and addsMaskViewlive-marker counting to skip the marker pre-pass when unused; mask “before/after” reconciliation is moved into a newMaskStabilizer. Adds extensive new propagation tests and updates the TestApp to exercise masking (e.g. enabling webview masking and adding.ldMask()examples).Reviewed by Cursor Bugbot for commit 52db5f0. Bugbot is set up for automated code reviews on this repo. Configure here.