Draft
Conversation
lexbritvin
reviewed
Jun 30, 2025
plugins/actionscobra/cobra.go
Outdated
| defaultJSON = string(jsonBytes) | ||
| } | ||
| } | ||
| val = flags.StringP(param.Name, param.Shorthand, defaultJSON, desc+" (JSON format)") |
Collaborator
There was a problem hiding this comment.
We need tests on how it renders in the templates. Not sure what we have for the moment.
plugins/actionscobra/cobra.go
Outdated
| } | ||
| case jsonschema.Object: | ||
| // Handle object as a JSON string | ||
| defaultJSON := "{}" |
Collaborator
There was a problem hiding this comment.
We have defaults set elsewhere. Please, make it one way. Maybe define a new Cobra Value Handler. Object must work for arguments and options.
plugins/actionscobra/cobra.go
Outdated
| case *string: | ||
| return *v | ||
| str := *v | ||
| // Check for raw JSON prefix |
Collaborator
There was a problem hiding this comment.
I don't get it. Please, reflect in the documentation how to use objects.
iignatevich
force-pushed
the
cobra_object_support
branch
4 times, most recently
from
5d9caf6 to
76b5b56
Compare
iignatevich
commented
Jul 4, 2025
docs/actions.schema.md
Outdated
| 3. `integer` | ||
| 4. `number` - float64 values | ||
| 5. `array` (currently array of 1 supported type) | ||
| 6. `object` - parses string as json string into map[string]any |
Collaborator
Author
There was a problem hiding this comment.
update doc
test args and enums
iignatevich
force-pushed
the
cobra_object_support
branch
from
76b5b56 to
177a6ba
Compare
iignatevich
force-pushed
the
cobra_object_support
branch
from
177a6ba to
b57ca11
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.