fix: ensure replaced modules are required in go.mod during build#119
Open
andypost wants to merge 1 commit intolaunchrctl:mainfrom
Open
fix: ensure replaced modules are required in go.mod during build#119andypost wants to merge 1 commit intolaunchrctl:mainfrom
andypost wants to merge 1 commit intolaunchrctl:mainfrom
Conversation
andypost
force-pushed
the
87-fix
branch
3 times, most recently
from
374888e to
e04eaab
Compare
Collaborator
|
@andypost can you please rebase onto the latest main? The change for better documented replace is a good thing, and I don't want to dump this code. |
andypost
commented
Aug 15, 2025
When using --replace flag, the build process was skipping go get for
replaced modules but not adding them as requirements, causing Go
compilation errors ("replaced but not required").
Add ensureModuleRequired() that calls go mod edit -require with a
placeholder version before go get for replaced modules. Also include
core package in GONOSUMDB/GONOPROXY for no-cache builds.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Author
|
@lexbritvin new Claude suggests simple approach #130 (added updated docs here) |
Author
|
@lexbritvin see 8fc77a3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using the --replace flag, the build process was skipping go get for replaced modules but not adding them as requirements, causing Go compilation errors. This fix ensures replaced modules are properly required using go mod edit -require with placeholder versions.
Fixes #87
🤖 Generated with Claude Code