fix: properly quote volume paths with spaces in docker run output#139
Open
BlocksecPHD wants to merge 1 commit intolavie:masterfrom
Open
fix: properly quote volume paths with spaces in docker run output#139BlocksecPHD wants to merge 1 commit intolavie:masterfrom
BlocksecPHD wants to merge 1 commit intolavie:masterfrom
Conversation
Fixes issue lavie#134 - containers with volumes containing spaces would generate broken docker run commands. The volume paths are now properly quoted using shlex.quote() to ensure shell-safe output. Changes: - Modified parse_volumes() in inspector.py to quote all volume paths - Added unit tests for the quoting behavior The fix ensures that paths like '/path/with spaces/folder' are output as '/path/with spaces/folder' instead of breaking the command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue #134 - containers with volumes containing spaces would generate broken docker run commands.
Root Cause
The
parse_volumes()function ininspector.pywas not quoting volume paths, causing commands to break when paths contain spaces.Example from issue #134:
The space in "Music Drive" would break the generated command.
Fix
Modified
parse_volumes()to useshlex.quote()(already imported) for all volume paths:This ensures:
'/path/with spaces':/dest/normal/path:/destTesting
Added unit tests in
test_runlike.py:test_quote_path_with_spaces: verifies quoting behaviortest_quote_normal_path: verifies no unnecessary quotingtest_parse_volumes_with_spaces: verifies Inspector correctly handles paths with spacesAll tests pass.
Example
Fixes #134