feat: update of .json files before neodax release#530
feat: update of .json files before neodax release#530MaxMoskalenko wants to merge 7 commits intomasterfrom
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdded a new YELLOW token to two network asset lists; updated network 11155111 wallet to add guarantorAddress and guarantorTokenLimitRaw and expand allowedFeeTypes for several call types; appended new trusted addresses in both network 11155111 and network 1 wallet files. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@networks/1/wallet.json`:
- Around line 45-46: The address "0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde" in
the wallet JSON array is not EIP-55 checksummed; replace it with its checksummed
form (e.g., using ethers.utils.getAddress or web3.utils.toChecksumAddress) so it
matches the mixed-case format used by the other entries and prevents typos.
Locate the address string in the addresses array in wallet.json and update it to
the checksummed version, then run a quick validation (ethers.utils.getAddress)
to ensure no other addresses are non-checksummed.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: b34fa4f9-dc13-46aa-ada9-51780ee05a96
📒 Files selected for processing (2)
networks/1/wallet.jsonnetworks/11155111/wallet.json
| "0x69E848d9EBFda9F713cdE5fB92116DFE2c4B2c8F", | ||
| "0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde" |
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Verify the EIP-55 checksum for the address using Python
pip install eth-utils -q
python3 -c "
from eth_utils import to_checksum_address
addr = '0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde'
print(f'Checksummed address: {to_checksum_address(addr)}')
"Repository: layer-3/clearsync
Length of output: 1797
🏁 Script executed:
#!/bin/bash
# Install proper hashing backend and verify the EIP-55 checksum
pip install eth-hash[pycryptodome] -q
python3 -c "
from eth_utils import to_checksum_address
addr = '0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde'
checksum = to_checksum_address(addr)
print(f'Original address: {addr}')
print(f'Checksummed address: {checksum}')
"Repository: layer-3/clearsync
Length of output: 185
🏁 Script executed:
#!/bin/bash
# Read the wallet.json file to see all addresses
cat -n networks/1/wallet.json | head -50Repository: layer-3/clearsync
Length of output: 1347
Use EIP-55 checksummed address format for consistency.
The address on line 46 (0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde) is all lowercase, while all other addresses in this file use mixed-case EIP-55 checksum format. Checksummed addresses provide protection against typos.
♻️ Suggested fix
"0x69E848d9EBFda9F713cdE5fB92116DFE2c4B2c8F",
- "0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde"
+ "0x3a9624f9BB2Dc43E90c0699DDc4A9b6BEc147Cde"📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "0x69E848d9EBFda9F713cdE5fB92116DFE2c4B2c8F", | |
| "0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde" | |
| "0x69E848d9EBFda9F713cdE5fB92116DFE2c4B2c8F", | |
| "0x3a9624f9BB2Dc43E90c0699DDc4A9b6BEc147Cde" |
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@networks/1/wallet.json` around lines 45 - 46, The address
"0x3a9624f9bb2dc43e90c0699ddc4a9b6bec147cde" in the wallet JSON array is not
EIP-55 checksummed; replace it with its checksummed form (e.g., using
ethers.utils.getAddress or web3.utils.toChecksumAddress) so it matches the
mixed-case format used by the other entries and prevents typos. Locate the
address string in the addresses array in wallet.json and update it to the
checksummed version, then run a quick validation (ethers.utils.getAddress) to
ensure no other addresses are non-checksummed.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@networks/11155111/wallet.json`:
- Line 63: Remove the duplicated literal from trustedAddresses and stop
hard-coding currentAuthorizerAddress in that array; instead update the config
loader (the code that reads trustedAddresses and currentAuthorizerAddress) to
compute the effective trust set by merging trustedAddresses with the single
source-of-truth currentAuthorizerAddress (e.g., add currentAuthorizerAddress
into the resulting set at load time or dedupe there) so future authorizer
rotations only require updating currentAuthorizerAddress; update any code that
expects the address to be present in trustedAddresses to use the computed set
instead.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7d56ec38-0f15-4527-9b06-61c90e39466b
📒 Files selected for processing (1)
networks/11155111/wallet.json
| "0xdAD067C90af43948f2A389DFC93d94481A72705c", | ||
| "0x3a9941C3D7B2b02304dBFC7FC33809f77e2d2ef4", | ||
| "0xA67C2dfa3697E1b87bbBb6257a5B8FeAccBD201b" | ||
| "0xA67C2dfa3697E1b87bbBb6257a5B8FeAccBD201b", |
There was a problem hiding this comment.
🛠️ Refactor suggestion | 🟠 Major
Don't duplicate currentAuthorizerAddress inside trustedAddresses.
Line 63 hard-codes the same address already declared on Line 3. On the next authorizer rotation, the retired authorizer will stay trusted unless both fields are updated together.
♻️ Safer direction
Keep the authorizer in one source of truth and have the config loader derive the effective trust set from currentAuthorizerAddress instead of repeating the literal address here.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.
In `@networks/11155111/wallet.json` at line 63, Remove the duplicated literal from
trustedAddresses and stop hard-coding currentAuthorizerAddress in that array;
instead update the config loader (the code that reads trustedAddresses and
currentAuthorizerAddress) to compute the effective trust set by merging
trustedAddresses with the single source-of-truth currentAuthorizerAddress (e.g.,
add currentAuthorizerAddress into the resulting set at load time or dedupe
there) so future authorizer rotations only require updating
currentAuthorizerAddress; update any code that expects the address to be present
in trustedAddresses to use the computed set instead.
2 participants
Summary by CodeRabbit
New Features
Chores