Repository navigation
chore(deps): bump chisel to v1.5.1 - #42
Merged
Merged
Conversation
v1.5.1 ships the trie path conflict check (canonical/chisel#302) ungated, so the 0003 backport goes. 0004 (letFunny/chisel#29) now applies straight onto upstream's conflict.go; it gets its own CHISEL_HACKS=1 gate so unset keeps upstream's traversal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumps the chisel pin v1.5.0 -> v1.5.1.
upstream v1.5.1 = #325 (maintenance dates), #313 (current-archive fallback for recently-eol releases), #302 (trie path conflict check) and #290 (AGENTS.md only).
conflict.go, but with 0003 gone it would have run unconditionally. it now carries its own gate:newConflictTreesets aFastflag fromCHISEL_HACKS=1; unset = upstream's traversal (every child a candidate, fresh queues per path).cmd_cut.gois byte-identical between the two tags.tested:
go test ./...with patches applied, inubuntu/go:1.25-26.04_edge: all green with and withoutCHISEL_HACKS=1.internal/setup2.2s -> 0.9s with it set.make binaries ARCH=arm64ok;chisel-hacked --version->v1.5.1-hacked.bread-chisel-releases:{22.04,24.04,25.10,26.04,26.10}-arm64built,chisel/chisel-hacked --versionboth reportv1.5.1-hacked.flock, macOS host) -- leaning on ci for that + amd64 / s390x / ppc64le.