Repository navigation
ci: single required check for the main ruleset - #44
Merged
Merged
Conversation
ci-ok needs every other job, so the ruleset can require one stable name instead of each matrix job.
the job only loops over a few words; it can't hang.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds a
ci-okjob toci.yamlthat needs every other job and fails unless all of them succeeded. thedefaultruleset onmainalready has a required-status-checks rule, but its list is empty, so nothing blocks a merge today.if: always()so a failed / cancelled dependency failsci-okrather than skipping it (a skipped required check counts as passing).after this lands (and
ci-okhas run once, so github offers it), addci-okto the ruleset's required checks. direct pushes tomain(therelease: rNcommits) will then be refused too, unless an admin bypass is added.