feat(auth): bundled OAuth client provider - #84
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a third OAuth provider flavor,
BundledProvider, for services that offer neither dynamic client registration nor a pasteable token and whose console makes per-user app creation a chore. smorg's maintainer registers the app once and the client id and secret ship with the build, the way desktop calendar clients do. The token exchange and refresh post the secret, the CLI and the in-app connect modal skip the client-id prompt, config records no client id for such a tab, and logout still revokes.First user is the Google Calendar tab, which lands in the next PRs. Google rejects a secretless code exchange for a desktop client and accepts any loopback port, both verified live.
Replicated against Google from a scratch config with the real bundled client: login with no client id used the bundled one, a forced-expiry refresh went through and persisted, the calendar list answered on the refreshed token, and revocation returned true. The CLI and modal flows have no bundled manifest to drive yet; that check rides with the next PR.