feat(core): gate experimental integrations behind an env var - #88
Merged
Merged
Conversation
A manifest can mark itself experimental, and the registry registers it only when SMORG_EXPERIMENTAL names it. gcal is the first: its code is on main three milestones in, and without this a release would offer the half-built tab to everyone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an
experimentalflag toManifest. The registry only registers an experimental integration whenSMORG_EXPERIMENTALnames it, comma-separated, soSMORG_EXPERIMENTAL=gcal smorgbrings the calendar back and a plain run does not see it at all.gcal is three milestones in and already on main, so cutting any release from main today would offer a half-built Google Calendar tab to everyone on the tap. With the flag, main carries the code and offers nothing. Milestone 6 drops it.
tests/test_seams.pynow walksINTEGRATIONSinstead ofmanifests(): hiding an integration from a run must not hide its action keys from the check that they are bound.