Skip to content

Add Electric/Double/Upright Bass Clef #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
versilov wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Electric/Double/Upright Bass Clef #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eeac7b7
Add Electric Bass Clef
versilov Dec 31, 2022
99691ae
Rename bass8 clef to upright
versilov Dec 31, 2022
46c91d6
Merge branch 'leafo:master' into master
versilov Jan 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions static/js/st/components/staves.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,16 @@ export class FStaff extends Staff {
}
}

export class F8Staff extends Staff {
static defaultProps = {
keySignatureCenter: "F3",
upperRow: 26,
lowerRow: 18,
cleffImage: "/static/svg/clefs.F_change.svg",
staffClass: "f8_staff",
}
}

export class GrandStaff extends React.Component {
constructor(props) {
super(props)
Expand Down
11 changes: 11 additions & 0 deletions static/js/st/data.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,17 @@ export const STAVES = [
/>
},
},
{
mode: "notes",
name: "upright",
range: ["C2", "E4"],
render: function(props=this.state) {
return <F8Staff
ref={(staff) => this.staff = staff}
{...props}
/>
},
},
{
mode: "notes",
name: "grand",
Expand Down