fix(readme): note /api/kb/budget is disabled-by-default in production#114
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
The clickable link surfaces a structured 404 `{"code":"DISABLED"}`
response in production by design (ADR-0046 § Trade-offs — production
opacity defaults). Add an inline disclaimer so a reviewer clicking
the link sees the expected response shape and links it back to the
ADR rationale rather than reading it as a dead endpoint.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The link
/api/kb/budgetreturns 404{"code":"DISABLED"}in production (intentional per ADR-0046 § Trade-offs — production observability is opt-in viaENABLE_OBSERVABILITY_API=1). Without the disclaimer, a portfolio reviewer clicking the link sees only a bare 404 and may misread it as link rot. Add a one-clause inline note so the response shape is expected, not surprising.