feat: expand built-in piano library with curated scores and cover art#10
Open
leandrodaf wants to merge 2 commits into
Open
feat: expand built-in piano library with curated scores and cover art#10leandrodaf wants to merge 2 commits into
leandrodaf wants to merge 2 commits into
Conversation
- musicxml.go: auto-detect and transcode UTF-16 LE/BE (with or without BOM) encoded MXL archives to UTF-8 before XML parsing - go.mod: promote golang.org/x/text to direct dependency - app.go: resolve local cover images from embedded data/library/covers/ when meta.coverUrl is empty, matching by filename stem
Adds piano scores across classical and contemporary genres,
all in the lib__{composer}__{title}.pia naming convention
and merged cleanly into the existing data/library/ collection.
Categories included:
- Classical: Bach, Beethoven, Brahms, Chopin, Debussy, Grieg, Handel,
Haydn, Liszt, Mendelssohn, Mozart, Prokofiev, Scarlatti, Schubert,
Schumann, Scriabin, Satie
- Contemporary: Adele, Billie Eilish, Coldplay, Dua Lipa, Elton John,
Linkin Park, One Direction, and others
- Exercises: scales, chord trainers, hand-position studies
69 cover images added to data/library/covers/ matching each score
by filename stem for local fallback display.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the built-in library from 144 to 222 piano scores, adds 69 cover images, fixes MusicXML import reliability, and corrects a widespread note-sustain bug in converted scores.
Changes
Infrastructure
musicxml.go: auto-detect and transcode UTF-16 LE/BE (with or without BOM) MXL archives to UTF-8 before XML parsinggo.mod: promotegolang.org/x/textto direct dependencyapp.go: resolve local cover images from embeddeddata/library/covers/by filename stem whenmeta.coverUrlis emptyLibrary expansion (+78 scores, +69 covers)
All files follow the
lib__{composer}__{title}.pianaming convention. New composers and categories:Exercise)Bug fix: tied-note micro-artifacts in MusicXML conversions
MusicXML tied notes were being emitted as 0 ms NoteOn/NoteOff pairs at every tie-stitch point, causing notes to silently re-attack instead of sustaining.
Fix: at any timestamp where the same note has both a NoteOn and NoteOff event, both are removed — the preceding NoteOn sustains naturally to its final unpaired NoteOff.