Skip to content

feat: Completeness for generic logics#476

Open
markusdemedeiros wants to merge 30 commits into
masterfrom
completeness-main-theorem
Open

feat: Completeness for generic logics#476
markusdemedeiros wants to merge 30 commits into
masterfrom
completeness-main-theorem

Conversation

@markusdemedeiros

Copy link
Copy Markdown
Collaborator

Description

Depends on #475

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros markusdemedeiros force-pushed the completeness-main-theorem branch from a7be10f to 77560c3 Compare July 7, 2026 08:13
@markusdemedeiros markusdemedeiros marked this pull request as ready for review July 15, 2026 15:09
@markusdemedeiros markusdemedeiros requested a review from lzy0505 July 15, 2026 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant