Skip to content

feat: saved propositions#503

Open
markusdemedeiros wants to merge 5 commits into
masterfrom
savedprop
Open

feat: saved propositions#503
markusdemedeiros wants to merge 5 commits into
masterfrom
savedprop

Conversation

@markusdemedeiros

@markusdemedeiros markusdemedeiros commented Jul 7, 2026

Copy link
Copy Markdown
Collaborator

Description

Saved propositions

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros markusdemedeiros marked this pull request as ready for review July 8, 2026 07:11
@markusdemedeiros markusdemedeiros requested a review from Kaptch July 8, 2026 07:11
@lzy0505 lzy0505 linked an issue Jul 10, 2026 that may be closed by this pull request
@Kaptch

Kaptch commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Thank you! I will start reviewing tomorrow :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Port base_logic/lib/saved_prop.v

2 participants