Skip to content

Fix: simp and rw sometimes exit the ProofMode#506

Open
lzy0505 wants to merge 1 commit into
leanprover-community:masterfrom
lzy0505:proofmode-iris-hyp-wrapper
Open

Fix: simp and rw sometimes exit the ProofMode#506
lzy0505 wants to merge 1 commit into
leanprover-community:masterfrom
lzy0505:proofmode-iris-hyp-wrapper

Conversation

@lzy0505

@lzy0505 lzy0505 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Fixes #469. The hack seems to work.

As I wrote in the comments, I think it is kabstract that causes the issue. It is probably a bug?

Checklist

  • My code follows the mathlib naming and code style conventions
  • I have added my name to the authors section of any appropriate files

Generative AI Guidelines

AI assistance is permitted when making contributions to Iris-Lean, however, generative AI systems tend to produce code which takes a long time to review.
Please carefully review your code to ensure it meets the following standards.

  • Your PR should avoid duplicating constructions found in Iris-Lean or in the Lean standard library.
  • have statements that do not aid readability or code reuse should be inlined.
  • Your proofs should be shortened such that their overall structure is explicable to a human reader. As a goal, aim to express one idea per line.
  • In general, proofs should not perform substantially more case splitting than their Rocq counterparts.

In our experience, a good place to begin refactoring is by re-arranging and combining independent tactic invocations.
We also find that pointing generative AI systems to the Mathlib code style guidelines can help them perform some of this refactoring work.

@markusdemedeiros

Copy link
Copy Markdown
Collaborator

I think I'm not the right one to evaluate this, but it seems reasonable?

@lzy0505 lzy0505 requested a review from MackieLoeffel July 10, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

simp can exit the ProofMode

2 participants