Revert: changes to shared_hbm #548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppotapov-aws
requested review from
govereau,
jiancheng-aws,
joonwonc,
jtristan,
kerrijoe-aws,
seanmcl,
waahm7 and
yongweiy
as code owners
ppotapov-aws
force-pushed
the
ppotapov/revert_shared_hbm_logic
branch
from
2789f0f to
e9326eb
Compare
Revert "FIX: follow up on outputs. Account for LNC" This reverts commit 2ead7a5. Revert "Regenerate CPP artifact after recent changes" This reverts commit bf9c76e. Revert "Rename the outputs" This reverts commit f929b66. Revert "[NKI-391] simplify lnc passes with tensor visitor" This reverts commit 8a75cee. Revert "[NKI-391] Canonicalize outputs from LNC kernels" This reverts commit 06a7f59. Revert "[NKI-393] process shared constant passed in as a string" This reverts commit 6c52a63. Revert "Dont dedup sharedBuffers for lnc == 1" This reverts commit 1ca4ae0. Revert "Make sure if shared_hbm seems to be placed incorrectly, we alrert the user" This reverts commit 148ffb4. Revert "[NKI-83]: add a list of shared tensors declared in kernels" This reverts commit afdf976. Regenerate cpp files
ppotapov-aws
force-pushed
the
ppotapov/revert_shared_hbm_logic
branch
from
e9326eb to
70deb93
Compare
aws-qieqingy
approved these changes
Dec 17, 2025
govereau
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "FIX: follow up on outputs. Account for LNC"
This reverts commit 2ead7a5.
Revert "Regenerate CPP artifact after recent changes"
This reverts commit bf9c76e.
Revert "Rename the outputs"
This reverts commit f929b66.
Revert "[NKI-391] simplify lnc passes with tensor visitor"
This reverts commit 8a75cee.
Revert "[NKI-391] Canonicalize outputs from LNC kernels"
This reverts commit 06a7f59.
Revert "[NKI-393] process shared constant passed in as a string"
This reverts commit 6c52a63.
Revert "Dont dedup sharedBuffers for lnc == 1"
This reverts commit 1ca4ae0.
Revert "Make sure if shared_hbm seems to be placed incorrectly, we alrert the user"
This reverts commit 148ffb4.
Revert "[NKI-83]: add a list of shared tensors declared in kernels"
This reverts commit afdf976.
Regenerate cpp files