refactor(Computability): remove h_mono from PolyTimeComputable.comp - #845
Open
BoltonBailey wants to merge 3 commits into
Open
BoltonBailey wants to merge 3 commits into
BoltonBailey wants to merge 3 commits into
Conversation
BoltonBailey
marked this pull request as draft
August 28, 2026 19:55
BoltonBailey
marked this pull request as ready for review
August 28, 2026 20:20
crei
approved these changes
Sep 2, 2026
crei
left a comment
crei
left a comment
Collaborator
There was a problem hiding this comment.
To be honest, I'm not a big fan of pulling in all of polynomials just to define polynomial time, but this is a good increment, and we need the machinery in any case.
Collaborator
|
Looks good to me! It just needs a rebase: the conflict is only the RelatesInSteps import path after #926. Optionally, the polynomial lemmas could use Semiring instead of CommSemiring, and eval_le_eval_of_le could become a @[gcongr] eval_mono. |
SamuelSchlesinger
approved these changes
Sep 23, 2026
SamuelSchlesinger
left a comment
SamuelSchlesinger
left a comment
Collaborator
There was a problem hiding this comment.
Approved whenever you rebase, ideally include the recommended improvements but we can do them in a follow on if not.
…able.comp Add TimeComputable.withMonotoneBound and PolyTimeComputable.withMonotoneBound, which replace a time bound with its partialSups (a monotone bound), and use them in PolyTimeComputable.comp so callers no longer need to supply a monotonicity proof. Add Polynomial.monotone_eval for canonically ordered semirings in Cslib/Foundations/Data/Polynomial/Monotone.lean. Supersedes leanprover#396. Co-authored-by: John Jennings <JohnEdwardJennings@users.noreply.github.com> Co-authored-by: Aristotle (Harmonic) <aristotle-harmonic@harmonic.fun> Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
BoltonBailey
force-pushed
the
remove-h-mono
branch
from
September 23, 2026 23:42
ab87f1b to
7f72de5
Compare
BoltonBailey
requested review from
arademaker,
kim-em and
sorrachai
as code owners
September 23, 2026 23:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #378.
This removes the
h_mono : Monotone hg.timeBoundassumption fromPolyTimeComputable.comp, by providing a way to convert a (poly)time-computable function into one with a monotone time bound.This PR supersedes #396, because that one seems abandoned, and it looks like this change is desired by some others.
Co-authored-by: John Jennings JohnEdwardJennings@users.noreply.github.com
Co-authored-by: Aristotle (Harmonic) aristotle-harmonic@harmonic.fun
🤖 Generated with Claude Code