ci(nightly-testing): link the failing commit in the failure message - #939
Merged
SamuelSchlesinger merged 1 commit intoSep 23, 2026
Merged
Conversation
On a `workflow_run` event, `github.sha` is the head of the default branch, not the commit whose CI run failed. Use `github.event.workflow_run.head_sha` so the failure message links to the `nightly-testing` commit that actually failed, matching the run link, which already uses `workflow_run.id`.
jessealama
requested review from
SamuelSchlesinger,
arademaker,
chenson2018,
fmontesi,
kim-em and
sorrachai
as code owners
September 23, 2026 07:50
SamuelSchlesinger
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a
workflow_runevent,github.shais the head of the default branch, not the commit whose CI run failed. The failure message posted to Zulip therefore linked the wrong commit. Usegithub.event.workflow_run.head_shainstead, matching the run link, which already usesworkflow_run.id.Pointed out by @kim-em in #914.