perf: JsonNumber comparison no longer eagerly aligns mantissa #11750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mantissa alignment is only used in the final else branch, so we can delay its computation. (I noticed this when reading the code, not when running it, so it's possible the compiler is already smart enough to perform this optimization, and probably this is not much of a bottleneck in practice.)
github-actions
bot
added
the
toolchain-available
Collaborator
|
Mathlib CI status (docs):
|
leanprover-bot
added a commit
to leanprover/reference-manual
that referenced
this pull request
Dec 20, 2025
leanprover-bot
added
the
builds-manual
Collaborator
|
Reference manual CI status:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this when reading the code, not when running it, so it's possible the compiler is already smart enough to perform this optimization, and probably this is not much of a bottleneck in practice.