fix(server): treat empty-string env vars as unset in config validation - #3
Draft
dnplkndll wants to merge 1 commit into
Draft
fix(server): treat empty-string env vars as unset in config validation#3dnplkndll wants to merge 1 commit into
dnplkndll wants to merge 1 commit into
Conversation
…AR: ${VAR}` lines fall back to defaults instead of failing validation (twentyhq#21035)
dnplkndll
force-pushed
the
fix/server-empty-env-vars-as-unset
branch
from
July 26, 2026 21:34
365379d to
2dc5aeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses failure mode (1) of twentyhq#21035.
Compose passes
VAR: ${VAR}for many optional variables, so any var unset onthe host reaches the server as
''— and boot validation rejects it instead ofapplying the documented default:
validate()now strips empty-string entries beforeplainToClass(matchingcompose's own "empty means unset" semantics) and logs which vars were treated
as unset. Explicit invalid non-empty values still fail as before.
Tests: valid value honored, compose-shaped batch of empties → defaults,
invalid non-empty still throws. Full twenty-config module: 198/198.