Skip to content

Eeprom editor#366

Merged
trns1997 merged 7 commits intomasterfrom
eeprom_editor
Apr 7, 2026
Merged

Eeprom editor#366
trns1997 merged 7 commits intomasterfrom
eeprom_editor

Conversation

@leducp
Copy link
Copy Markdown
Owner

@leducp leducp commented Apr 1, 2026

Closes #277

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 1, 2026

File Coverage Lines Branches
All files 78% 81% 75%
lib/include/kickcat/Error.h 91% 100% 83%
lib/include/kickcat/SBufQueue.h 80% 98% 63%
lib/master/src/Bus.cc 90% 92% 89%
lib/master/src/CoE.cc 61% 71% 51%
lib/master/src/Link.cc 98% 100% 97%
lib/master/src/MailboxSequencer.cc 97% 100% 94%
lib/master/src/MasterOD.cc 99% 98% 100%
lib/master/src/Prints.cc 95% 95% 95%
lib/master/src/Slave.cc 21% 39% 3%
lib/master/src/dc.cc 0% 0% 0%
lib/slave/src/AbstractESC.cc 92% 100% 84%
lib/slave/src/AbstractEmulatedEEPROM.cc 0% 0% 0%
lib/slave/src/ESMStates.cc 96% 98% 94%
lib/slave/src/ESM.cc 95% 100% 90%
lib/slave/src/PDO.cc 92% 97% 88%
lib/slave/src/ESC/EmulatedESC.cc 57% 63% 51%
lib/slave/src/ESC/Lan9252.cc 0% 0% 0%
lib/src/Frame.cc 98% 100% 97%
lib/src/Mailbox.cc 90% 94% 86%
lib/src/SIIParser.cc 40% 50% 30%
lib/src/protocol.cc 94% 92% 96%
lib/src/CoE/EsiParser.cc 93% 95% 90%
lib/src/CoE/OD.cc 98% 98% 98%
lib/src/CoE/protocol.cc 93% 93% 94%
lib/src/CoE/CiA/DS402/StateMachine.cc 93% 94% 92%
lib/src/CoE/mailbox/request.cc 80% 84% 76%
lib/src/CoE/mailbox/response.cc 93% 97% 88%
lib/src/EoE/protocol.cc 0% 0% 0%

Minimum allowed coverage is 75%

Generated by 🐒 cobertura-action against affd73d

@trns1997
Copy link
Copy Markdown
Collaborator

trns1997 commented Apr 1, 2026

Tested with lan9252 and it works :)

trns1997
trns1997 previously approved these changes Apr 1, 2026
@trns1997 trns1997 dismissed their stale review April 1, 2026 18:12

just reopenned the save file and it is not loading the contents correctly of the eeprom. example SM and FMMU fields

@trns1997
Copy link
Copy Markdown
Collaborator

trns1997 commented Apr 2, 2026

  • Generate EEPROM from scratch, save and test

@trns1997
Copy link
Copy Markdown
Collaborator

trns1997 commented Apr 6, 2026

Problem List Cannot edit:

  • Identity (Hex)
  • Bootstrap Mailbox (Hex)
  • Standard Mailbox (Hex)
  • Sync Manager Start Address (Hex)

Underlying issue is that hex data cannot be written unless they are read only data then it needs to be explicitly stated

@trns1997
Copy link
Copy Markdown
Collaborator

trns1997 commented Apr 6, 2026

Problem List Cannot edit:

* Identity (Hex)

* Bootstrap Mailbox (Hex)

* Standard Mailbox (Hex)

* Sync Manager Start Address (Hex)

Underlying issue is that hex data cannot be written unless they are read only data then it needs to be explicitly stated

Fixed thanks to latest commit. Successfully created from scratch and loaded eeprom

ImGui::Separator();
if (ImGui::MenuItem("Quit", "Ctrl+Q"))
{
std::exit(0);
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://stackoverflow.com/questions/7054685/are-destructors-run-when-calling-exit

doesn'nt imgui have its own close method thats potentially safer?

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so? In this case I think it is safe: we are closing the app so any unsaved work will be lost as expected.

@trns1997 trns1997 merged commit 51b364e into master Apr 7, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EEPROM/ESI editor

2 participants