fix: retain Android Dawn compatibility for LiteRT 0.17.1 - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LiteRT-LM v0.17.1 leaves the Android Dawn inputs unchanged, but the version-keyed override table currently drops the existing arm64/x64 correction when selecting that tag. This retains the exact checksummed overrides for v0.17.1 and extends compatibility/version-floor tests across the existing nine target configurations.
This is compatibility preparation, not qualified v0.17.1 adoption. No runtime/consumer/qualification pins change. The Windows DXIL fix remains separate. No issue closure is requested.
Validation: 183 local tooling tests pass with one platform-dependent skip; 21 diagnostics tests pass. Independent exact-head review at 2128df3 against 3eb4079 found no blocking code findings and independently passed 31 focused tests plus per-architecture checksum-rejection/preservation, provenance, and unknown-version checks. Exact-source component probes passed 13 Rust tests and 48 llguidance numeric grammar controls; production Rust/C++ conversion preserves integers above 2^53 and i64 limits.
Remaining qualification gates:
The ordinary automatic PR workflow performs nine-target qualification using its unchanged v0.17.0 source pin. Those checks are baseline regression evidence, not v0.17.1 runtime qualification. No manual workflow dispatch, artifact publication, or downstream adoption is part of this PR.
Automatic hosted CI completed successfully on 2026-09-18 at exact head
2128df3c3da431f7daf66e2866aac4d7131d322fagainst base3eb4079397d19e2058e176fcdb5ab15b28a70ad0: all 17 checks passed, including nine build/smoke targets, candidate verification, SentencePiece sanitizers, publication lifecycle, and Qwen inference on Linux x64, Windows x64, and macOS arm64. Qualification run. Final review-thread query returned no threads. PR #53 remains draft. These are v0.17.0 baseline checks; the v0.17.1 gates above remain open.Follow-up qualification (separate from this preparation patch): a downloaded official v0.17.1 macOS archive matching SHA256
83efd536485c9d58fcd7fb7d4556ddb16ca46bb775b0449d08d9825c6836c1a4fails a direct arm64 production-parser probe. All 18 integer cases across FC/Python/JSON serialize as doubles, and9007199254740993rounds down. Independent review verified exact archive bytes, library loading, and symbol binding. This confirms the macOS prebuilt lacks the promised integer behavior; it is component evidence, not public Dart/model or iOS qualification. PR marked ready only for its compatibility-preparation scope after fresh independent review; no adoption or merge claim.