Use maps instead of objects for begin/end turns - #74
Open
simlmx wants to merge 2 commits into
Open
Conversation
Maps are iterated in the order of insertion, whereas objects's key are iterated in a custom order that depends on the keys. In ours case keys are user ids. Having the order not depend on the user ids makes unit testing simpler down the line.
simlmx
force-pushed
the
use-maps-for-turns
branch
from
July 1, 2026 18:27
b9940f3 to
c762626
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Maps are iterated in the order of insertion, whereas objects's key are iterated in a custom order that depends on the keys. In ours case keys are user ids. Having the order not depend on the user ids makes unit testing simpler down the line.