Skip to content

KB: review merged PR #316 - feat(cli): standardize Honeycomb service interface #317

Description

@github-actions

A merged PR may require knowledge-base updates. Review the change and update library/ as needed.

Source PR

  • PR: #316 - feat(cli): standardize Honeycomb service interface
  • Author: @thenotoriousllama
  • Merged into: main
  • Files changed: 47

PR description

Summary

  • standardize Honeycomb on the Apiary CLI interface while retaining all 37 product-specific commands
  • add real lifecycle, service, update, registration, status, log, and telemetry adapters
  • add Honeycomb branding, exact attribution, strict JSON/exit behavior, migration documentation, and packed-tarball conformance
  • harden Windows service ownership, exact descendant cleanup, updater rollback, uninstall boundaries, output sanitization, and fixed subprocess invocation

Verification

  • Quality: A / PASS; 50 applicable criteria passed, 3 external proofs; 0 open Critical, Warning, or Suggestion findings
  • Security: 10 High findings fixed; 0 open Critical or High findings
  • CI: 477 files / 5,196 tests passed; 13 skipped
  • full 12-command packed human/JSON success, runtime-failure, and usage-failure matrix
  • 71-file package check, SQL-safety audit, OpenClaw audit, and npm audit with 0 vulnerabilities
  • live Windows global-tarball dogfood: install, start, stop, restart, idempotent start, service install/uninstall/reinstall, status, register, logs, telemetry, update-check, help/version, JSON, and exit codes
  • final installed service has one exact Scheduled Task descendant owning port 3850

External close-out

Native privileged/reboot CI across all operating systems, the four-product suite job, and published-release proof remain suite-level PRD-003 close-out work.

Summary by CodeRabbit

  • New Features
    • Added/expanded CLI verbs (restart, logs, status, service install/uninstall, register) with standardized help/branding and consistent --json/color behavior.
    • Introduced stricter packed-CLI conformance and added cross-platform smoke checks.
  • Bug Fixes
    • Install/uninstall now fail closed on required-phase failures; uninstall confirmation is enforced.
    • Update now verifies health before/after and performs validated rollback when verification fails.
    • Improved Wi

Files touched

  • .claude-plugin/marketplace.json (+2/-2)
  • .claude-plugin/plugin.json (+1/-1)
  • .github/workflows/ci.yaml (+31/-1)
  • CHANGELOG.md (+14/-0)
  • README.md (+15/-4)
  • esbuild.config.mjs (+185/-176)
  • harnesses/claude-code/.claude-plugin/plugin.json (+1/-1)
  • harnesses/codex/package.json (+1/-1)
  • harnesses/openclaw/openclaw.plugin.json (+1/-1)
  • harnesses/openclaw/package.json (+1/-1)
  • package-lock.json (+12/-2)
  • package.json (+4/-1)
  • scripts/fixtures/packed-cli-driver.mjs (+153/-0)
  • scripts/pack-check.mjs (+17/-5)
  • scripts/packed-cli-conformance.mjs (+219/-0)
  • scripts/prepare-packed-artifact.mjs (+28/-0)
  • src/cli/daemon-service.ts (+194/-14)
  • src/cli/health-probes.ts (+18/-19)
  • src/cli/runtime.ts (+42/-39)
  • src/cli/standard-ops.ts (+438/-0)
  • src/commands/contracts.ts (+18/-2)
  • src/commands/dispatch.ts (+253/-58)
  • src/commands/index.ts (+0/-1)
  • src/commands/install.ts (+24/-15)
  • src/commands/local-handlers.ts (+45/-58)
  • src/commands/packed-conformance.ts (+8/-0)
  • src/commands/standard-interface.ts (+228/-0)
  • src/commands/telemetry.ts (+48/-13)
  • src/daemon/index.ts (+16/-1)
  • src/daemon/runtime/telemetry/emit.ts (+5/-1)
  • src/shared/fixed-subprocess.ts (+21/-0)
  • src/shared/fleet-detection.ts (+21/-21)
  • src/shared/fleet-root.ts (+28/-1)
  • tests/cli/daemon-service-pinning.test.ts (+3/-3)
  • tests/cli/daemon-service.test.ts (+217/-9)
  • tests/cli/health-probes.test.ts (+29/-1)
  • tests/cli/standard-ops.test.ts (+305/-0)
  • tests/cli/uninstall-lifecycle-steps.test.ts (+39/-0)
  • tests/commands/__snapshots__/standard-interface.test.ts.snap (+254/-0)
  • tests/commands/dispatch.test.ts (+70/-10)
  • tests/commands/install.test.ts (+5/-8)
  • tests/commands/lifecycle-verbs.test.ts (+64/-12)
  • tests/commands/standard-interface.test.ts (+470/-0)
  • tests/commands/telemetry-wiring.test.ts (+41/-0)
  • tests/daemon/runtime/telemetry/emit.test.ts (+12/-0)
  • tests/shared/fleet-detection.test.ts (+24/-5)
  • tests/shared/fleet-root.test.ts (+32/-1)

Auto-generated by .github/workflows/kb-issue-on-merge.yaml on merge.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    knowledgeKB update prompted by a merged PR

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions