Conversation
feat: remove self headers, migrated to nats headers
KinitaL
reviewed
Nov 12, 2025
|
|
||
| func (r *eventRouterImpl) AddEventHandler(subject string, handler EventHandleFunc, opts *EventHandlerOptions, middlewares ...EventMiddlewareFunc) { | ||
| if subject == "" { | ||
| panic("empty event subject name") |
There was a problem hiding this comment.
паники не очень прикольно ловить, можем подумать, как это обвязать так, чтобы у чела тупо не было возможности передать пустую строку? Но при этом без паник
KinitaL
reviewed
Nov 12, 2025
KinitaL
reviewed
Nov 12, 2025
feat: graceful shutdown tests
fix: add middlewares in events
refactor: make examples actual docs: update readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.