Skip to content

Remove deprecated k= argument alias from Top-N metrics#1073

Open
mdekstrand wants to merge 3 commits intolenskit:mainfrom
mdekstrand:tweak/remove-rank-k
Open

Remove deprecated k= argument alias from Top-N metrics#1073
mdekstrand wants to merge 3 commits intolenskit:mainfrom
mdekstrand:tweak/remove-rank-k

Conversation

@mdekstrand
Copy link
Copy Markdown
Member

This removes the deprecated k= argument from top-N metrics in favor of n=, for consistency across LensKit that list lengths are n.

Closes #889.

@mdekstrand mdekstrand added this to the 2026.1 milestone Apr 13, 2026
@mdekstrand mdekstrand self-assigned this Apr 13, 2026
@mdekstrand mdekstrand modified the milestones: 2026.1, 2027.1 Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.59%. Comparing base (dc16ad7) to head (baf8613).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1073      +/-   ##
==========================================
+ Coverage   89.48%   89.59%   +0.10%     
==========================================
  Files         231      187      -44     
  Lines       15867    13192    -2675     
==========================================
- Hits        14199    11819    -2380     
+ Misses       1668     1373     -295     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdekstrand mdekstrand removed this from the 2026.1 milestone Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated 'k' alias in metrics

1 participant