Better handle cacheable-flash transitioners#48
Open
jaredhales wants to merge 2 commits intoleonid-shevtsov:masterfrom
Open
Better handle cacheable-flash transitioners#48jaredhales wants to merge 2 commits intoleonid-shevtsov:masterfrom
cacheable-flash transitioners#48jaredhales wants to merge 2 commits intoleonid-shevtsov:masterfrom
Conversation
The `cacheable-flash` gem is no longer maintained and the author suggests `unobtrusive_flash` as its successor: https://github.com/pboling/cacheable-flash However, the flash cookie format is different between these two libraries. This patch will make the transition from one to the other more painless (and as an added side effect also to help to handle tampered cookies that may not be in the expected format). I manually did this locally for our project and figured others might benefit from it as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
cacheable-flashgem is no longer maintained and the author suggestsunobtrusive_flashas its successor: https://github.com/pboling/cacheable-flashHowever, the flash cookie format is different between these two libraries. This patch will make the transition from one to the other more painless (and as an added side effect also to help to handle tampered cookies that may not be in the expected format). I manually did this locally for our project and figured others might benefit from it as well.