Skip to content

Added support for AXFR query #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
RobertoBochet wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added support for AXFR query #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pydig/query_type.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ class QueryType(Enum):
DNSKEY = 48
CDS = 59
CDNSKEY = 60
AXFR = 252
CAA = 257

@classmethod
Expand Down
2 changes: 1 addition & 1 deletion pydig/resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ def _args(self, domain, query_type):
yield query_type.name

# We only care about the result
yield '+short'
yield from ('+noall', '+answer') if query_type == query_type.AXFR else ('+short',)
Copy link
Copy Markdown
Author

@RobertoBochet RobertoBochet Dec 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AXFR is not a DNS entry, it is a kind of DNS query aims to extract all the DNS entries of a DNS zone, for this reason the dig output is useless without the DNS entry type. So I decided to return the full entry and not the short version.

This chose is thought in order to maintain the retro compatibility with last version. In a second moment I suggest to redefine the output schema of the library.


# Add in any additional args
yield from self.additional_args
Expand Down