fix(deps): upgrade vitest ^2→^4 to patch 5 moderate CVEs and remove duplicate script key#21
Open
leopechnicki wants to merge 1 commit intomainfrom
Open
fix(deps): upgrade vitest ^2→^4 to patch 5 moderate CVEs and remove duplicate script key#21leopechnicki wants to merge 1 commit intomainfrom
leopechnicki wants to merge 1 commit intomainfrom
Conversation
…uplicate typecheck script key esbuild ≤0.24.2 (pulled in by vitest ^2.x → vite → @vitest/mocker) allows any cross-origin page to query the dev server and read responses (GHSA-67mh-4wv8-2f99). Upgrading vitest from ^2.0.0 to ^4.1.0 pulls in esbuild ≥0.25 and resolves all 5 moderate advisories. Also removes the duplicate "typecheck" key in the scripts object (lines 21 and 24 were identical), which caused vitest to warn on every test run. All 263 tests continue to pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vitestfrom^2.0.0to^4.1.0, resolving 5 moderate CVEs in theesbuild→vite→@vitest/mockerchain (GHSA-67mh-4wv8-2f99). esbuild ≤0.24.2 allowed any cross-origin page to query the dev server and read responses."typecheck"key inpackage.json(lines 21 and 24 were identical), which caused vitest to warn on every test run.Changes
package.json— removed duplicatetypecheckscript; bumpedvitestfrom^2.0.0to^4.1.0package-lock.json— updated lockfile to reflect new dependency tree (0 vulnerabilities)Test plan
npm installcompletes with 0 vulnerabilities (down from 5 moderate)npm test— all 263 tests pass with vitest v4.1.5npm run typecheck— no TypeScript errorsnpm run lint— no lint warningsRisk assessment
Low. The vitest v4.x API is backwards-compatible with v2.x for the patterns this project uses (plain
describe/it/expect). All existing tests pass without modification.Generated by Crew — Leo's Agile Dev Team
Generated by Claude Code