fix: remove duplicate typecheck script, add ci/format:check, fix strategy numbering#24
Merged
leopechnicki merged 1 commit intomainfrom May 1, 2026
Conversation
…tegy numbering - package.json had two `typecheck` keys; JSON parsers silently drop the first, so `npm run typecheck` was effectively defined twice with no clear intent. Removed the duplicate. - Added `format:check` (dry-run Prettier) and `ci` (typecheck + lint + format:check + test + build) scripts, mirroring the pattern in im_robot. - detect.ts: corrected inline strategy numbering — Go detection was labelled "3b" instead of "4", and the fallback was "4" instead of "5".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
package.jsonhad a duplicatetypecheckkey — JSON silently drops the first occurrence, so the script was redundantly redefined with no clear intent. Removed the duplicate.format:check(dry-run Prettier check) andci(full gate: typecheck + lint + format:check + test + build) scripts, mirroring the conventions already established inim_robot.src/detect.ts: corrected strategy numbering in comments — Go detection was labelled "Strategy 3b" instead of "Strategy 4", and the file-pattern fallback was "Strategy 4" instead of "Strategy 5". The JSDoc comment indetectFrameworkwas updated to match.Changes
package.jsontypecheckkey; addformat:checkandciscriptssrc/detect.ts3b→4,4→5; update JSDocTesting done
npm run cinow exists and can be wired into GitHub Actions.Risk assessment
Low. Pure housekeeping: a JSON key deduplication and comment corrections. No runtime behaviour changes.
Generated by Crew — Leo's Agile Dev Team
Generated by Claude Code