Skip to content

fix(ui): use process.exit(0) instead of Ink exit() in handleExit to e… #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ArvinQi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ui): use process.exit(0) instead of Ink exit() in handleExit to e… #219

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions packages/cli/src/ui/views/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,10 +315,10 @@ function App({ projectRoot, initialPrompt, resumeSessionId, onRestart }: AppProp
}

sessionManager.dispose();
exit();
process.exit(0);
}, 0);
},
[exit, sessionManager]
[sessionManager]
);

const handlePrompt = useCallback(
Expand Down Expand Up @@ -414,6 +414,13 @@ function App({ projectRoot, initialPrompt, resumeSessionId, onRestart }: AppProp
setRunningProcesses(
finalActiveSessionId ? (sessionManager.getSession(finalActiveSessionId)?.processes ?? null) : null
);
// Auto-exit after initial -p/--prompt submission completes, without
// relying on the busy effect which can miss the transition when React
// batches setBusy(true) and setBusy(false) into the same render.
if (initialPromptSubmittedRef.current) {
initialPromptSubmittedRef.current = false;
handleExit({ showCommand: false, showSummary: true });
}
}
},
[
Expand Down Expand Up @@ -562,6 +569,15 @@ function App({ projectRoot, initialPrompt, resumeSessionId, onRestart }: AppProp
void run();
}, [handleSubmit, handleSelectSession, initialPrompt, navigateToSubView, refreshSessionsList, resumeSessionId]);

// Auto-exit after -p/--prompt initial submission completes
const prevBusyRef = useRef(busy);
useEffect(() => {
if (prevBusyRef.current && !busy && initialPromptSubmittedRef.current) {
handleExit({ showCommand: false, showSummary: true });
}
prevBusyRef.current = busy;
}, [busy, handleExit]);

const handleDeleteSession = useCallback(
async (id: string): Promise<void> => {
const isActiveSession = sessionManager.getActiveSessionId() === id;
Expand Down