Stream mode complete#137
Open
merv1n34k wants to merge 15 commits into
Open
Conversation
Imported from a larger change by @merv1n34k as part of "Stream mode: Phase 3" (let-def#125).
Contributor
Author
|
UPD: bring back previous fix from #125 for And also update |
Contributor
Author
|
On top of that, also replaced legacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @let-def!
I have rebased your changes on top of the main. Few things added after #130:
1. Bug fix
editor_notify_lookupineditor.chas a switch with no break statements — every(lookup-file ...)notification falls through toabort()and crashestexpresso.Fix: add
breakafter each case. 3 lines change.2. Feature:
(pause)/(resume)In
-streammode,texpressostarts compiling immediately, before the editor has a chance to push the root file. The engine fails, the editor sendsregister+open, and the engine restarts. With multiple files this means several wasted restarts at startup.(pause)lets the editor freeze the engine while priming the VFS:The engine then steps once with everything already in place. Works in both sexp and JSON. Backward compatible — clients that never pause behave identically.
Implementation: new
EDIT_PAUSE/EDIT_RESUMEcommands,pausedflag onpersistent_state, guards on everyengine_stepcall site. Test script included (make test-pause-resume).Seems this is the last bit, and I could finally move towards stream mode wiring to the
texpresso.vim(texpresso.nvim) and my other project.