Skip to content

don't route navigation/editing keys through NSTextInputClient #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
levovix0 merged 1 commit into from
Mar 8, 2026
Merged

don't route navigation/editing keys through NSTextInputClient #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 17 additions & 3 deletions src/siwin/platforms/cocoa/window.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1346,9 +1346,23 @@ proc init =
modifiers: modifiers,
)

# Let key events handle deletion keys directly; routing them through
# NSTextInputClient commands can suppress subsequent key presses.
let shouldRouteToInputContext = key notin [Key.backspace, Key.del]
# Let key events handle navigation/editing control keys directly;
# routing them through NSTextInputClient can suppress following key presses.
let shouldRouteToInputContext = key notin {
Key.backspace,
Key.del,
Key.left,
Key.right,
Key.up,
Key.down,
Key.home,
Key.End,
Key.pageUp,
Key.pageDown,
Key.tab,
Key.enter,
Key.escape,
}
if window.eventsHandler.onTextInput != nil and shouldRouteToInputContext:
var handledByInputContext = false
let inputContext = cast[NSView](self).inputContext
Expand Down