Revert direct push; re-land via PR - #74
Closed
r0h1tb wants to merge 1 commit into
Closed
Conversation
Temporary: the content landed straight on main, which should have gone through a PR. Re-submitted unchanged in feat/production-readiness; merge that after this one and the net tree is identical.
Collaborator
Author
|
Closing per author: content stays on main; direct pushes are acceptable here. Keeping this open would pointlessly churn history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: 8 commits (the fix/first-run-experience merge, the sig wrapped/named-param fix, gitignore guard, run docs) landed directly on main instead of through a PR.
Fix: single revert commit restoring the main tree to
14327eb(git diff 14327eb HEADis empty).Tests: none needed — pure revert. The content is re-submitted unchanged in the
feat/production-readinessPR opened alongside this one. Merge order: this one first, then that one.