Scroll agent-browser and Ferrum targets into view before clicking - #29
Merged
lanyue-llk merged 1 commit intoSep 22, 2026
Merged
Conversation
lanyue-llk
changed the base branch from
main
to
codex/moli-benchmark-harness-fix
September 22, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coordinate-based click operations can report success while the target center is outside the viewport, leaving checkout or checkbox state unchanged. Use each adapter's native scroll-into-view operation before clicks and checks, including every repeated click.
The change is limited to agent-browser and Ferrum. These adapters are not used by the 12 Moli regression cases (raw CDP, chromiumoxide and Playwright), so their corrections are submitted separately and do not contribute to that cohort's pass count.
Validation: JavaScript and Ruby syntax checks plus git diff --check pass. Both files match the earlier evaluated patch byte for byte. Earlier recorded visibility-fix runs passed 10/10 per engine for each adapter (20/20 combined per adapter); no extra benchmark cases were rerun for this PR, respecting the current 12-case-only scope.
Report and frozen evaluator patch: https://artifact-site.lexmount.cn/v/WiF5KVJ_Ta2lgsaj3r81hCejInBl4u1f
Targets the same
codex/moli-benchmark-harness-fixbranch as harness PR #25 and PR #28. The comparison remains limited to the two adapter files.Review illustrations and evidence
完整验证报告：逐项根因、Chromium 对照与原始证据
本 PR 的适配器可见性修正不参与报告中原始 12 项的通过率，也不属于 Moli 或 Stylo 的引擎修复。