fix(release): synchronize 1.2.3 versions and reject mismatched tags - #32
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf98af4b83
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Verify compiled version before signing | ||
| shell: bash | ||
| run: | | ||
| actual="$(target/aarch64-apple-darwin/release/browser-cli --version)" |
There was a problem hiding this comment.
Run the version check on a matching macOS architecture
In build-macos, the macos-14 hosted runner is Intel/x86_64, while this command attempts to execute the newly built aarch64-apple-darwin binary. Every matching tagged release will therefore fail here with an incompatible-architecture error before signing, packaging, and publishing; use an ARM runner or verify the embedded version without executing the cross-compiled binary.
Useful? React with 👍 / 👎.
Problem
The published
v1.2.2tag includes #31, but Cargo and both Skill bootstrap defaults remained1.2.1. Release filenames alone therefore advertised a version the executable did not report, and new Skill installs selected the previous binary.Changes
1.2.3consistently in Cargo.toml, the root Cargo.lock package, and both bootstrap defaults. Keep already-published v1.2.2 tags/assets/checksums unchanged.--versionbefore packaging (and before macOS signing).Validation / self-review
6931e7fis rejected when checked with tagv1.2.2.cargo fmt --check,cargo clippy --all-targets --locked -- -D warnings, shell syntax, workflow YAML/dependency-order checks andgit diff --checkpassed.1.2.3via both--versionand structuredversion.The public v1.2.2 release notes now warn about the mismatch. After this PR is merged and CI passes, publish a new v1.2.3 tag on the merged commit, verify GitHub/COS downloads and Skill pins, then link the replacement from v1.2.2. Do not rebuild/overwrite v1.2.2. Full WorkBuddy product regression is separate and will use the corrected release.