fix: native click input and Windows Skill diagnostics (1.2.4) - #34
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HTMLElement.click()with native CDP mouse move/press/release input. The old implementation can report success whilewindow.open()receives no user activation and is blocked.eval.doctordirectly; use the harness's existing Bash tool when PowerShell omits stdout/stderr; require the actual readiness JSON. Keep normal execution policy and sandbox permissions.Commits
Verification before PR
isTrusted=false, user activation false, popup not opened. It passes with native input on full Chrome 151.0.7922.108.cargo test --all-targets --locked: 60 passed; the 3 opt-in browser tests were run separately.--offline: 60 passed.cargo test --release --locked --test page_targets_browser -- --ignored --nocapture: 3/3 passed. Includes 23 actionability scenarios, same-tab navigation, unchanged arbitrary-eval semantics, popup discovery, explicit reconnects and closed-target no-fallback behavior.cargo fmt --all -- --check,cargo clippy --all-targets --locked -- -D warnings, andgit diff --check: passed.Boundaries