Skip to content

chore: rename to jev-browser-bridge - #5

Merged
waple0820 merged 3 commits into
mainfrom
chore/rename-jev-browser-bridge
Sep 24, 2026
Merged

waple0820 merged 3 commits into
mainfrom
chore/rename-jev-browser-bridge

Conversation

@waple0820

Copy link
Copy Markdown
Contributor

Renames the project to jev-browser-bridge, which says what it does: a bridge from any browser to Jev.

Changed everywhere it appeared (every occurrence found by a case-insensitive search for nolayout):

Old New
Jev NoLayout (title, prose) Jev Browser Bridge
jev-nolayout (repo, distribution, CLI, clone URL) jev-browser-bridge
jev_nolayout (module) jev_browser_bridge
__jevNoLayout* (page globals the snapshot installs) __jevBridge*

The only remaining match is the phrase "needs no layout at all" in a docstring, which describes the method, not the name.

Nothing breaks for existing users:

  • import jev_nolayout still works: a compatibility package re-exports the new module, submodules included, with a DeprecationWarning.
  • The jev-nolayout command stays as an alias of jev-browser-bridge.
  • The GitHub repo is already renamed; the old URL redirects.

Checked: lint clean; old and new imports resolve to the same classes; both commands run; a typing task on Lightpanda completes in 3 steps (exercises the renamed page globals).

Still to do: the overview diagram still reads "Jev NoLayout" — a redrawn one is coming separately.

The name now says what it does: a bridge from any browser to Jev. The repo,
the distribution, the CLI and the module are renamed, along with the page
globals the snapshot installs (__jevBridge*).

jev_nolayout stays as a compatibility package that re-exports the new one
(with a DeprecationWarning), and the jev-nolayout command stays as an alias,
so existing imports and scripts keep working.

Signed-off-by: waple0820 <feng.wang@lexmount.com>
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Claude finished @waple0820's task in 51s —— View job


No bugs or security issues found. The rename is mechanically consistent across Python, JavaScript, and config.

One thing to be aware of: DeprecationWarning is silenced by default in non-development Python environments, so users running installed packages won't see the migration warning unless they opt in (e.g. python -W default). This is standard Python behaviour and not a defect, but worth noting in release notes.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Claude review completed. Review run: https://github.com/lexmount/jev-browser-bridge/actions/runs/36001567341. Please check Claude's inline feedback and summary comment for details.

Signed-off-by: waple0820 <feng.wang@lexmount.com>
A DeprecationWarning is hidden outside development environments, so the
people who most need to update their import would never see it. Use a
FutureWarning, which Python shows by default.

Signed-off-by: waple0820 <feng.wang@lexmount.com>
@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Review in progress

  • Read key changed files
  • Check for bugs and security issues
  • Post findings

View job run

@waple0820

Copy link
Copy Markdown
Contributor Author

Two updates:

  • The overview diagram is redrawn with the new name (assets/overview.png, same path).
  • Took the review's note: the rename notice is now a FutureWarning, which Python shows by default, instead of a DeprecationWarning, which it hides outside development. import jev_nolayout now prints: jev_nolayout is now jev_browser_bridge; update the import.

@github-actions

github-actions Bot commented Sep 24, 2026 •

Copy link
Copy Markdown

Claude finished @waple0820's task in 44s —— View job


Review

No bugs or security issues found.

One correction to the previous automated comment: the compatibility shim uses FutureWarning, not DeprecationWarning. FutureWarning is visible to end-users by default in Python — no opt-in required. The PR description explains this choice explicitly.

The JS global renames (__jevNoLayout* → __jevBridge*) are consistent across all four distinct globals in snapshot.js and browser.py.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated Claude review completed. Review run: https://github.com/lexmount/jev-browser-bridge/actions/runs/36001864204. Please check Claude's inline feedback and summary comment for details.

@waple0820
waple0820 merged commit 6767cb3 into main Sep 24, 2026
1 check passed
@waple0820
waple0820 deleted the chore/rename-jev-browser-bridge branch September 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant