Skip to content

fix(tests): rename integration temp dir lockr_tests to seal_tests - #10

Merged
lextpf merged 1 commit into
lextpf:mainfrom
VedantMadane:fix/seal-tests-temp-dir-name
Aug 27, 2026
Merged

lextpf merged 1 commit into
lextpf:mainfrom
VedantMadane:fix/seal-tests-temp-dir-name

Conversation

@VedantMadane

Copy link
Copy Markdown
Contributor

Summary

  • Rename the integration-test scratch directory from legacy lockr_tests to seal_tests so it matches the project and GoogleTest executable name.

Test plan

  • Confirmed single occurrence of lockr_tests replaced in tests/test_integration.cpp
  • CI test workflow

Fixes #8

Align FileOperationsTest scratch directory with the seal_tests executable name after the project rename.

Fixes lextpf#8

Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric Results
Complexity 0
Duplication 0

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@lextpf lextpf self-assigned this Aug 25, 2026
@lextpf

lextpf commented Aug 27, 2026

Copy link
Copy Markdown
Owner

Hi @VedantMadane ,

Thanks for jumping in so quickly, having another pair of eyes on this is always appreciated! 😊
Your changes look good and you have my approval! I'll merge this back ASAP

If you'd like to dive in deeper as a contributer:

The project is a bit opaque about where assets live and it's a bit tricky to set up your own assets which means runtime testing can be quite cumbersome, if you'd like to test locally yourself here are two easy ways to get you up and running in case you want to be more hands-on for future issues:

What you might need How to get it Notes
Full pre-built project from your branch ➜ Add me on Discord (@lextpf). Unzip anywhere and run the executable.
Only the assets (if you want to build yourself) ➜ Add me on Discord (@lextpf). After cloning the repo, drop the assets/ folder from this ZIP into the repo root, then build.

Let me know if you need support and we can arrange something, and thanks again for volunteering and helping improve Seal, you're always welcome to work on future issues! 🦭

Alex

@lextpf
lextpf merged commit f9b4270 into lextpf:main Aug 27, 2026
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Integration test creates temp directory at lockr_tests (legacy project name)

2 participants