Handle empty CARGO overrides in Makefile#177
Draft
lodyai[bot] wants to merge 1 commit into
Draft
Conversation
Resolve the cargo executable before target definitions and treat an explicitly empty `CARGO` value as unset. This keeps local caller overrides working while preventing CI environments that export `CARGO=` from building commands with an empty executable.
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
github-actions
Bot
added
size: XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch keeps Makefile tool discovery working when CI exports
CARGO=asan empty value. It resolves the cargo executable separately, treats empty
CARGOas unset, and preserves non-empty caller overrides.Review walkthrough
NEXTESTwiring.Validation
make -n check-fmt CARGO=: passed; dry-run commands use the resolved cargo path.make all: passed; 3977 nextest tests passed, 7 skipped, and GitHub tool tests passed.git diff --check: passed.Notes
This branch is split out from the WASM registration refactor so the toolchain
resolution behaviour can be reviewed independently.