Reduce builder core assertion blocks (#40)#198
Draft
leynos wants to merge 1 commit into
Draft
Conversation
Refactor builder core tests to replace dense assertion runs with tracked semantic helpers and `rstest` parameterised cases. Keep the change test-only so builder behaviour remains unchanged while making future failures easier to read.
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
Reviewer's GuideRefactors builder core tests to use shared assertion helpers and rstest parameterization, reducing duplicated assertion blocks while preserving test coverage and semantics. File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
(1 files improve in Code Health)
Gates Failed
(1 file with Excess Number of Function Arguments)
Gates Passed
See analysis details in CodeScene
Reason for failure
| Enforce advisory code health rules | Violations | Code Health Impact | |
|---|---|---|---|
| tests.rs | 1 advisory rule | 8.82 → 9.10 | Suppress |
View Improvements
| File | Code Health Impact | Categories Improved |
|---|---|---|
| tests.rs | 8.82 → 9.10 | Large Assertion Blocks |
Quality Gate Profile: Pay Down Tech Debt
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Comment on lines
+82
to
+99
| pub(super) fn assert_build_result_failure( | ||
| res: &BuildResult, | ||
| expected_error: &str, | ||
| expected_warnings: usize, | ||
| tests_passed: u32, | ||
| tests_failed: u32, | ||
| ) { | ||
| assert_build_failure_contains(res, expected_error); | ||
| assert_eq!( | ||
| ( | ||
| res.validation_warnings.len(), | ||
| res.tests_passed, | ||
| res.tests_failed, | ||
| res.registered, | ||
| ), | ||
| (expected_warnings, tests_passed, tests_failed, false) | ||
| ); | ||
| } |
There was a problem hiding this comment.
❌ New issue: Excess Number of Function Arguments
assertions.assert_build_result_failure has 5 arguments, max arguments = 4
github-actions
Bot
added
size: L
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch reduces the large assertion blocks in the builder core tests by moving repeated checks into semantic helper assertions and by parameterizing language command cases with
rstest. The change is test-only and preserves the existing builder behaviour while making failures easier to interpret.Closes #40.
Review walkthrough
assertionshelpers and the#[track_caller]annotations.rstestcases in src/tools/builder/core/tests.rs for language extension, build command and test command coverage.Validation
cargo test tools::builder::core::tests: passed, 29 builder core tests.make all: passed, including format checks, clippy configurations, default nextest with 4,122 passed tests, and 5 GitHub tool tests.src/tools/builder/core/tests.rsexceeded three consecutive assertion macro lines.coderabbit review --agent: attempted three times, but CodeRabbit returned usage-credit rate-limit errors before producing a review.Notes
This branch does not change production code or feature parity status.
Summary by Sourcery
Refine builder core tests by extracting shared assertion helpers and parameterizing language command coverage without changing production behavior.
Enhancements:
Tests: